To be honest I think Mel played Riggs as himself, if you look at his roles he's always got that manic thing going on where you're not sure if he's unhinged or not (and for a while in real life he was apparently). So it was more like he was just letting some bottled up version of himself out for the performances. Even in Maverick he has the manic thing going.